Auth data persists across app delete

uber / uber-ios-sdk

Uber iOS SDK (beta)

https://developer.uber.com/docs

MIT License

376 stars 125 forks source link

Auth data persists across app delete #101

Open dayitv89 opened 8 years ago

dayitv89 commented 8 years ago

User token stored in keychain and when app deleted and again install, ride sdk read user data from keychain and old user data is accessible. What if user token expires it request for re-auth?

User token can be deleted by the TokenManager.deleteToken() only.

Why not store a variable in user-default for checking first run, and if the variable not found clean auth token, insist of show old user data.

jbrophy17 commented 8 years ago

Yes this is true, NSKeyedArchiver does not delete data when an app is uninstalled. Other apps cannot access this data, but I agree it would be useful to have it clear on a fresh install.

dayitv89 commented 8 years ago

@jbrophy17 Have a look to PR #102 for this.