search

uber / uber-ios-sdk

Uber iOS SDK (beta)
https://developer.uber.com/docs
MIT License
376 stars 125 forks source link

Empty scope returned from SSO login in new Uber app v3.219.12 #128

Closed samwize closed 7 years ago

samwize commented 8 years ago

In the new Uber app released on 4 Nov, there is a critical breaking change.

During a SSO login, the granted scope is empty, even though the requested scope is indeed given.

In AccessToken.swift L108, scopesString now erroneously has %20 instead of space. Example: it should be profile ride_widgets instead of profile%20ride_widgets.

jbrophy17 commented 8 years ago

Looks like a url encoding issue, thanks for bringing this up, going to look into it right now

jbrophy17 commented 8 years ago

Found the issue with the encoding, working on a fix. In the meantime, your access tokens still work correctly for the requested scopes, it is just a bug with correctly notifying you which scopes were requested

jbrophy17 commented 7 years ago

Sorry on the delay here, SSO should be correctly returning scopes now as of Uber version 3.221

No SDK update is necessary