search

uber / uber-ios-sdk

Uber iOS SDK (beta)
https://developer.uber.com/docs
MIT License
375 stars 125 forks source link

Swifty APIs (Pt 2) #177

Closed edjiang closed 7 years ago

edjiang commented 7 years ago

Reduce complexity of the RideParameters model by removing the builder associated with it.

RideParameters represents the set of parameters sent via a deeplink, ride request widget, or the ride estimate/request API endpoints.

In the previous implementation, the primary thing the builder added was to ensure that the RideParameters were immutable. However, I don't think there is a huge issue around mutability with this model, and the builder pattern is not super common in Swift anyways.

bobz commented 7 years ago

Conditional approval, but let's go back and add immutability with a simplified builder.