uber / uber-ios-sdk

Uber iOS SDK (beta)
https://developer.uber.com/docs
MIT License
376 stars 125 forks source link

Migrate to Swift 4 #178

Closed edjiang closed 7 years ago

edjiang commented 7 years ago

Migrate to Swift 4 using the auto migrator + manual audits of the migration.

The primary impact of Swift 4 on our codebase is that Swift 4 no longer automatically generates Objective-C entry points for subclasses of Objective C objects. Since our codebase is meant to be consumed from Objective-C clients as well as Swift only clients, we need to add @objc annotations to tell the compiler to still generate these entry points.

See:

Also, the private access control modifier gained a bit of scope, making fileprivate unnecessary for the most part.

See: