search

uber / uber-ios-sdk

Uber iOS SDK (beta)
https://developer.uber.com/docs
MIT License
375 stars 125 forks source link

Driver smsNumber maked optional #188

Closed piotr-sekara closed 6 years ago

piotr-sekara commented 6 years ago

Fixed a bug that caused a problem with loading the current ride because of null value for a driver sms number that we've received from API in Sandbox. Before that fix, when ride was in "accepted" state, we've received a json from API where sms number was null, so we were getting nil ride when calling "fetchCurrentRide" function because UberRides was decoding this json, and trying to get value for non optional String.

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

edjiang commented 6 years ago

The PR looks good, but let me see if this is a bug in the sandbox first. I don't think the SMS number should actually ever be null...

edjiang commented 6 years ago

I was wrong. There are instances where the smsNumber can be null. Thanks for the fix!