search

uber / uber-ios-sdk

Uber iOS SDK (beta)
https://developer.uber.com/docs
MIT License
375 stars 125 forks source link

Unable to subclass RideRequestViewController #191

Closed codyrotwein closed 6 years ago

codyrotwein commented 6 years ago

Can you change RideRequestViewController to open instead of public so that I can override/subclass it?

edjiang commented 6 years ago

Just curious, what are you trying to accomplish with the subclass? We may be making some changes in this area in the near future, so we don't want to accidentally break subclasses.

Otherwise, you might be able to get by for now by copy-pasting the RideRequestViewController into your code.

codyrotwein commented 6 years ago

Thanks for getting back to me Edward. I'm mainly subclassing it in order to update the navigation bar buttons, as well as do some custom things related to the menu controller I'm using in my app and some analytics type stuff.

I'd rather not have to copy-paste RideRequestViewController or modify the Uber source. Please let me know if you guys have plans to change it to open.

Thanks, Cody

On Tue, Oct 10, 2017 at 8:13 PM, Edward Jiang notifications@github.com wrote:

Just curious, what are you trying to accomplish with the subclass? We may be making some changes in this area in the near future, so we don't want to accidentally break subclasses.

Otherwise, you might be able to get by for now by copy-pasting the RideRequestViewController.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/uber/rides-ios-sdk/issues/191#issuecomment-335643880, or mute the thread https://github.com/notifications/unsubscribe-auth/AF27_rpt8QJqL4pAsE0OKkGipMN4DSafks5srAg8gaJpZM4PyohZ .

edjiang commented 6 years ago

Ride Request Widget was deprecated in 0.9, so I'm closing this as a non-issue anymore. Sorry!

https://github.com/uber/rides-ios-sdk/releases/tag/v0.9.0

https://developer.uber.com/docs/riders/change-log