search

uber / uber-ios-sdk

Uber iOS SDK (beta)
https://developer.uber.com/docs
MIT License
375 stars 125 forks source link

Remove Login Views #196

Closed edjiang closed 6 years ago

edjiang commented 6 years ago

Since we are moving to SFAuthenticationSession and SFSafariViewController, with fallback to regular Safari for web-based authentication flows, we do not need any login views anymore.

This PR removes the login views.

edjiang commented 6 years ago

There is no use case where we would need to fallback to an embedded web view.

Here's how the application will decide between how to present the login views:

I decided to use external Safari instead of embedding a web view in the iOS 8 case because RFC 8252 8.12 now discourages native applications from using embedded web views for doing OAuth for various security reasons.

In addition, it's less code complexity since external Safari returns a response to the AppDelegate in the same way as SFSafariViewController, reducing code complexity.