Closed lhasiuk closed 6 years ago
Thanks @lhasiuk! Let me take a look at this and get it merged for you :)
Hey @lhasiuk, I have some changes that I'd like to push to your branch, before merging. They should fix the tests and add an additional test to verify this behavior. Could you please allow me to push to your branch?
https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/
@edjiang Allow edits from maintainers is already enabled.
Published to Cocoapods, 0.8.1. Thanks so much for your help!
Uber Android SDK Authentication issue for "User cancel login" Solved
https://github.com/uber/rides-ios-sdk/issues/90#issuecomment-459646713
Fixed a bug where the system dialog box:
"" wants to open "Uber"
Cancel / Open
would cause SSO to fail because the system dialog triggers the UIApplicationDidBecomeActive notification. The fix is to make sure that the notification is preceded by a UIApplicationWillEnterForeground notification, which happens only when the there's been a context switch to the Uber app.
Fixed a related bug where, if the user were to select Cancel in the system dialog box (above), the library would attempt to use fallback to a web view, when the correct handling would be to stop attempting to log in and return an error to the caller.