uber / uber-ios-sdk

Uber iOS SDK (beta)
https://developer.uber.com/docs
MIT License
376 stars 125 forks source link

TokenManager, AccessToken migration #299

Closed mohssenfathi closed 5 months ago

mohssenfathi commented 5 months ago

Description

New TokenManager and AccessToken classes were added in a previous PR. This PR migrates any classes still using TokenManager_DEPRECATED and AccessToken_DEPRECATED to the new ones. It also removes the deprecated classes.

Changes

AccessGroup Support

To keep feature parity, support was added for setting a custom access group when performing any keychain operations.

Updated call sites

UberCore and UberRides classes (RidesRequestView, LoginManager, etc.) were updated to reference a new instance of TokenManager instead of the static TokenManager_DEPRECATED. Logic and functionality should remain the same. Note: LoginManager will be removed eventually.

Additional AccessToken initializers

An AccessToken extension with custom inits was added to support UberRides classes.

Testing

https://github.com/uber/rides-ios-sdk/assets/5241321/713c0f2a-c89c-4098-b405-1da7380dfc8e