This PR cleans up the existing Swift SDK sample app so that it is runnable / testable. The long term goal is that functionality and tests from this legacy sample app will be merged into the new UberSDK sample app.
Changes
Auth Tests
Legacy auth related tests have been removed. Supporting classes like LoginManager and Authenticators were removed in a previous PR.
Token Management
Some Rides classes like RideRequestView and VC required some changes to inject the accessGroup and tokenIdentifier to be able to successfully save/retrieve them. In a future PR, we may expose the underlying auth manager instance to these classes so they can manage the auth lifecycle better.
RidesAPI Deprecation
While not officially marked as deprecated, we will not be maintaining the Rides APIs, so our responsibility will be only to maintain a working state.
Token Refresh
Placeholders were included for token refresh tests. These will be updated once it's implemented.
Testing
Open and run the SwiftSDK sample app.
Open and run all tests in the SwiftSDK sample app.
Description
This PR cleans up the existing Swift SDK sample app so that it is runnable / testable. The long term goal is that functionality and tests from this legacy sample app will be merged into the new UberSDK sample app.
Changes
Auth Tests
Legacy auth related tests have been removed. Supporting classes like LoginManager and Authenticators were removed in a previous PR.
Token Management
Some Rides classes like RideRequestView and VC required some changes to inject the accessGroup and tokenIdentifier to be able to successfully save/retrieve them. In a future PR, we may expose the underlying auth manager instance to these classes so they can manage the auth lifecycle better.
RidesAPI Deprecation
While not officially marked as deprecated, we will not be maintaining the Rides APIs, so our responsibility will be only to maintain a working state.
Token Refresh
Placeholders were included for token refresh tests. These will be updated once it's implemented.
Testing