Closed adamlaz closed 4 years ago
Hi @adamlaz, thanks so much for reporting the issue! I actually (just finally) am getting to my annual "what's broken in my FF report app this year" check, and lo and behold, I ran into the same issue as you. It is because the API being used for the arrest data appears to no longer be publicly accessible, so the calls to it are failing.
I have already implemented a solution (you will be able to simply turn off that functionality completely to skip over it), which I will be pushing soon. I'll close this issue once it's pushed! Then that should give me time to try and figure out if I can find an alternative to the API and implement it.
That's awesome to hear @uberfastman!
Excited to play with this a bit, so I'll be keeping an eye on the repo for any updates š¤: š . It's been a few years since I've done anything non-trivial in Python. Maybe as I poke around I can think of a way I can help add some functionality and will open a PR.
Sideote: thank you for actually replying thoughtfully to my issue! I always feel a bit weird opening an issue on a random repo with a dump of logs when I can't even get it to run locally. I was happy to read that this wasn't just some dumb thing I was doing on my machine š
@adamlaz I'm always glad to get input, and anything you feel like contributing with PRs would be great!
Also, I've pushed release v8.0.1-beta, which includes the default disabling of the Bad Boy rankings while I explore a fix for that missing API. I guess I can always go back to my original implementation when I was scraping the USA Today data myself, but it's always nicer and easier to maintain with an API.
I'm closing the issue since it should be fixed for you, but please reopen it if it doesn't!
@adamlaz just FYI, I fixed the NFL arrest data retrieval, so the bad boy data has been reinstated as part of the app.
@uberfastman thanks! Going to try and find some time this weekend to play with all this.
@adamlaz awesome, I look forward to seeing what you come up with, as Iām always looking for fun new metrics to add! I apologize ahead of time for the massive pain the ass it is to add a metric... the overall app is still rather messy and could probably use yet another massive refactor/overhauls haha.
Let me know if you run into any other setup issue!
Hey - I'm getting the below error when trying to generate a report. I'm getting ESPN data successfully, but can't seem to get past this.... Any help would be appreciated!
pyenv
but I don't think that would affect this.config.ini
I triedleague_bad_boy_rankings = False
but that didn't seem to help, it still tries to get the data.