[Bug] function attribute not working correctly get_game_metadata_by_game_id(game_id).game_key

[hkingsley]

Description of Issue

function attribute not working correctly get_game_metadata_by_game_id(game_id).game_key

so unable to use query.get_league_info()

Yahoo Fantasy Sports League ID

122731

Yahoo Fantasy Sports League Privacy

Public

Operating System/Environment

Ubuntu

Other

Any other setup/environment/configuration information you might deem potentially relevant.

[hkingsley]

looks like its affecting more than just query.get_league_info() also query.get_league_standings()

[uberfastman]

Hi @hkingsley, thanks for the bug report. With the latest major version release of YFPY, I made a change in how you set up the YahooFantasySportsQuery object such that it now requires you to provide the game_code as part of instantiation. You can use nfl, mlb, nhl, or nba for the respective sports. What I'm guessing is happening though is if you didn't provide that positional argument but then had subsequent arguments, then the new class signature was picking up a value set for all_output_as_json_str, which would trigger it to be True, and thus all of our output would be converted to JSON strings instead of YFPY objects.

If you can show me how you were instantiating your YahooFantasySportsQuery object I can confirm if my suspicions are correct. I tried running all of the above methods with your league and had no issues retrieving the info as expected, so I think it might just be an issue with the setup due to that change I made in this last major version release.

[hkingsley]

@uberfastman Thank you for getting back to me! This is how i've instantiated YahooFantasySportsQuery

[uberfastman]

Ah phew, I was worried for a moment that something was broken. You need to just set all_output_as_json_str=False (or just exclude it as it defaults to False) and you should be all set.

I'm closing this but if anything persists just reopen it and add a comment!

[hkingsley]

@uberfastman Thank you all sorted

[uberfastman]

Great, glad it's sorted! Thanks for using YFPY!