search

ubergeek42 / lambda-letsencrypt

Free Lets-Encrypt certificate management for CloudFront/AWS
MIT License
211 stars 37 forks source link

Missing custom headers on CloudFront update #22

Open 9b opened 8 years ago

9b commented 8 years ago

Update to the CloudFront Origins is missing a CustomHeader that will cause issues. The key is required, but no data needs to be filled in. You can add the following line to 475 to make it work properly:

'CustomHeaders': {u'Quantity': 0}

References: https://github.com/ubergeek42/lambda-letsencrypt/blob/master/lambda_function.py#L469-L474

ov3rk1ll commented 7 years ago

On a similar note: 'QueryStringCacheKeys': {'Quantity': 0} is needed in the ForwardedValues in line 493.

https://github.com/ubergeek42/lambda-letsencrypt/blob/master/lambda_function.py#L493-L496

tomari commented 7 years ago

I've already posted a pull request for this, but that hasn't been merged for some time now: https://github.com/ubergeek42/lambda-letsencrypt/pull/24