ubergeek77 / CCExtraGamepadOptions

A mod for CrossCode that adds some additional gamepad options.
1 stars 1 forks source link

Game crashes if mod is removed #1

Open 2767mr opened 1 year ago

2767mr commented 1 year ago

If the mod is removed the game will crash when entering the controller options

ubergeek77 commented 1 year ago

Oh. It sure does.

I can see why too. I'll see about a hotfix for it.

ubergeek77 commented 1 year ago

@2767mr You should be able to resolve this on your own by setting Gamepad Icons to "Xbox" or "Dualshock" before removing the mod, that way the vanilla game does not go out of index when loading the modded save. Or, if you have a save editor, you can ensure gamepad-icons is not set to 2, which is likely the case if you are experiencing the crash.

Alternatively, I have a hotfix for this here: https://github.com/ubergeek77/CCExtraGamepadOptions/tree/vanilla-crash-fix

If you load this version of the mod, open the options menu, then close (or really do anything that triggers a save), it should fix your save and allow it to be loaded into vanilla again.

I'm not pushing this to stable yet, as it isn't as stable as I would like. It generally works fine, but if the gamepad is set as the active controller before the options can load, it will just always show the Xbox icons until you trigger a gamepad change again. It seems I was relying on implicit behavior of the gamepad-icons option without even realizing it.

I'll need to look into a more intelligent way of loading this mod, sometime after sc.options has been fully loaded (it seems to return 0 for newly added items), but before the icons are needed. Perhaps I can do everything just before the title screen GUI loads, I will have to investigate.

Sorry for the trouble!

2767mr commented 1 year ago

This was reported by TronKitten#6082 and they fixed it by simply reinstalling the mod