ubergeek77 / Lemmy-Easy-Deploy

Deploy Lemmy the easy way!
MIT License
133 stars 14 forks source link

Upgrade to Git Commits? #43

Closed fmunim closed 1 year ago

fmunim commented 1 year ago

Did you check the FAQ & Troubleshooting section for answers to common questions and issues?

Yes

Describe the issue Is there a way to upgrade to Git commits instead of tags?

Diagnostic Information N/A

ubergeek77 commented 1 year ago

Yes, you can do -l git:<hash> or -w git:hash. You'll need to use -f too.

However, I tried doing a git build just today and the build failed, and I don't really have the capacity to fix their builds for them a second time :p

You can use those CLI args to build against a git commit, and if it fails/you need to make changes, you can use the -r flag to rebuild without clearing the git tree.

Do note that this is:

However, I should mention that I am building Docker images for every commit they tag, meaning I have 0.18.2-rc.2 images ready to pull. I think that has every security fix they've pushed recently, at least the most critical ones.

If your build fails, I won't be able to really help, but you can keep trying different things with the -r flag if you need to fix it. You can also take a look at my Dockerfiles in the repo I linked if their Dockerfiles are problematic for you.

fmunim commented 1 year ago

Thank you for the quick and detailed reply. So if I were to build using commits and it failed you saying -R would force it to build again without clean the working directory? Right?

ubergeek77 commented 1 year ago

Yep. I've basically got it set up like this:

https://github.com/ubergeek77/Lemmy-Easy-Deploy/blob/61827fdb13dc171316967c330794fe29ad48983c/deploy.sh#L1409-L1446

ubergeek77 commented 1 year ago

If you have any feedback about this, or any unexpected not-upstream-Lemmy issues, feel free to let me know. This build from source code is pretty old at this point, it was only there for myself, but ended up being replaced by my multiarch images which I use for myself now.

fmunim commented 1 year ago

Got it thank you again for this detailed answer. I will just stick with the tagged versions for now. Closing this.

ubergeek77 commented 1 year ago

Sounds good! You're probably asking about this due to all the recent security news. So, if you're keeping an eye on these security fixes, I am building all RC versions pretty much as soon as they are tagged (my server checks for missing tags every 20 minutes). If you see a new Lemmy tag, chances are I've already got an image for it before even the official images are ready, in which case you can do, for example:

./deploy.sh -l 0.18.2-rc.2 -f

(-l on its own implies -w of the same tag for convenience, you can also set -w to 0.18.0 or something if you want to stay there)

You can always see what the newest tags I have for each image by going to each package individually:

https://github.com/ubergeek77/lemmy-docker-multiarch/pkgs/container/lemmy https://github.com/ubergeek77/lemmy-docker-multiarch/pkgs/container/lemmy-ui

fmunim commented 1 year ago

Yes, I have noticed you are really fast. Which is great and I am so appreciative of you! I just saw more fixes with CORS in commits and they haven't tagged a new version yet. That's why I wanted to be ahead of security issues and use the commits instead. But again thank you so much!!