search

uberhalit / EldenRingFpsUnlockAndMore

A small utility to remove frame rate limit, change FOV, add widescreen support and more for Elden Ring
MIT License
1.19k stars 110 forks source link

Lack of acknowledgment #54

Closed l0lhax closed 2 years ago

l0lhax commented 2 years ago

Did you at least want to acknowledge the significant work of others for the FOV / aspect / 60hz fullscreen related patches you ripped from Flawless Widescreen? :D

duskyBabz commented 2 years ago

I just took a look at the code for the Elden Ring plugin from FWS and didn't see any sign of code being "ripped". What are you basing your accusation on exactly?

l0lhax commented 2 years ago

All the patch positions and mechanisms are the same, including my mistakes, for example - such as calculating delta time with (1000f / fps) / 1000f (it should be 1.0f / 60)

It's fairly obvious.

uberhalit commented 2 years ago

Hello, I wasn't aware of this tool yet but as I am seeing it on their website, Elden Ring is not listed as a supported title nor is the tool open source?

I am assuming with delta-time you are referring to the frame rate unlock? I released that a few hours after game release and my testers had that ready merely 20mins after midnight on release day as the entire function including this delta-time code segment is copied from my own Sekiro utility which has had that code since 25th of March 2019 which was its initial release on github: https://github.com/uberhalit/SekiroFpsUnlockAndMore/blob/master/SekiroFpsUnlockAndMore/MainWindow.xaml.cs#L887

I am not going to remove your comments as I am definitely not the only person who can come up with patches to an old engine quickly after release. But please consider this next time.