search

uberhalit / EldenRingFpsUnlockAndMore

A small utility to remove frame rate limit, change FOV, add widescreen support and more for Elden Ring
MIT License
1.21k stars 111 forks source link

fix CompilerService reference, add icon, include required System DLL's #9

Closed DubbleClick closed 2 years ago

DubbleClick commented 2 years ago

tackles #2 (and #8 )

uberhalit commented 2 years ago

Hi, thank you for your contribution. I've removed all unneccessary references. Didn't realize that Unsafe requires external DLLs on .NET 4.8. It is part of the framework itself on .NET 6.

For the Icon we have to concider CopyRights, I am going to add the old one as I have written permisson to use that.

DubbleClick commented 2 years ago

Hey, yeah that sounds like a good idea, unfortunately .ico was sneakily added to the gitignore so your icon resource didn't make it to github.

DubbleClick commented 2 years ago

considering the dependency on compilerservices.unsafe isn't even required anymore, this PR can safely be closed. please upload the icon though still :)

uberhalit commented 2 years ago

Hey, yeah that sounds like a good idea, unfortunately .ico was sneakily added to the gitignore so your icon resource didn't make it to github.

That's on purpose, I am not allowed to share the icon itself, only bundled into an app.