search

uberhalit / EldenRingFpsUnlockAndMore

A small utility to remove frame rate limit, change FOV, add widescreen support and more for Elden Ring
MIT License
1.19k stars 110 forks source link

Pre-existing steam_appid.txt is deleted #95

Open jvasileff opened 2 years ago

jvasileff commented 2 years ago

Any pre-existing steam_appid.txt is deleted when "Start game without EAC" is used.

As an attempted (but failed) workaround, if steam_appid.txt is marked readonly, "Start game without EAC" reports "Couldn't write steam id file!".

I think it would be better to avoid creating, modifying, or deleting steam_appid.txt if it already exists with the correct contents. Or, at least, don't delete the file if a file by the same name already existed.

uberhalit commented 2 years ago

Well the file will be recreated as soon as you restart the game with the first button. I added this as a weak security if a user wants to go online without the tool and forgets to delete the steam_appid file which would result in an EAC trigger and possible in a ban in the future.

What is your use case of using a custom steamID file?

jvasileff commented 2 years ago

I don’t always use this utility to launch the game. I was surprised at first when EAC was enabled when it should not have been, until I discovered this utility deletes the steamID file. It’s dangerous to use this tool unless you always use this tool, if you care about disabling EAC.

uberhalit commented 2 years ago

Keeping the file if it is present on start is not a bulletproof solution; if the utility crashes a single time the file will never get deleted ever again.

I'd argue that it would be more dangerous to let the steam_appid.txt in the folder without the users knowledge as they will be immediately flagged as soon as they try to start the game in online mode, even without loading a save. In contrast if we delete the file the user will get a big EAC splash screen on start indicating that EAC is running. As long as you don't load a save-game EAC won't check your games state anyway.

All I can offer is another checkbox to disable the steam_appid check.

jvasileff commented 2 years ago

I wasn't aware that the presence of steam_appid.txt is dangerous. If it is, I've been subjecting myself to much more risk than I thought.

My understanding:

Reference https://wiki.speedsouls.com/eldenring:EAC_Bypass. My second assumption isn't stated, but it does say:

Online play is still possible by quitting again and launching the game from Steam.

This is consistent with my experience. EAC is only bypassed when launching eldenring.exe directly, and not start_protected_game.exe, so the user will be aware they are attempting to bypass EAC.

For the idea:

All I can offer is another checkbox to disable the steam_appid check

I really appreciate the check that the file exists (and is correct), and wouldn't feel safe without it. Perhaps instead, a checkbox to disable the removal of the file if a file of the same name already existed?