ubermag / discretisedfield

Python package for the analysis and visualisation of finite-difference fields.
http://ubermag.github.io
BSD 3-Clause "New" or "Revised" License
19 stars 13 forks source link

Attempt: fix holoviews - xarray bug #494

Closed lang-m closed 1 year ago

lang-m commented 1 year ago
github-actions[bot] commented 1 year ago

PR Analysis

How to use

To invoke the PR-Agent, add a comment using one of the following commands: /review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option. /describe: Modify the PR title and description based on the contents of the PR. /improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback. /ask \<QUESTION>: Pose a question about the PR. /update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value For example: /review --pr_reviewer.extra_instructions="focus on the file: ..." To list the possible configuration parameters, use the /config command.

lang-m commented 1 year ago

@samjrholt I have disabled pre-commits for discretisedfield. I hope that maybe when we re-activate it later (after merging) the wrong error might disappear.

codecov-commenter commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (720a457) 93.12% compared to head (81a0e98) 93.16%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #494 +/- ## ========================================== + Coverage 93.12% 93.16% +0.03% ========================================== Files 28 28 Lines 3026 3027 +1 ========================================== + Hits 2818 2820 +2 + Misses 208 207 -1 ``` | [Files](https://app.codecov.io/gh/ubermag/discretisedfield/pull/494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ubermag) | Coverage ฮ” | | |---|---|---| | [discretisedfield/plotting/hv.py](https://app.codecov.io/gh/ubermag/discretisedfield/pull/494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ubermag#diff-ZGlzY3JldGlzZWRmaWVsZC9wbG90dGluZy9odi5weQ==) | `92.77% <100.00%> (+0.04%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/ubermag/discretisedfield/pull/494/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ubermag)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.