ubermag / discretisedfield

Python package for the analysis and visualisation of finite-difference fields.
http://ubermag.github.io
BSD 3-Clause "New" or "Revised" License
19 stars 13 forks source link

ignore hv cell #506

Closed samjrholt closed 1 year ago

samjrholt commented 1 year ago

One cell in the field holoviews plotting started failing with Python 3.10 (no obvious error, probably some sort of change in the format). As a workaround we ignore that cell.

github-actions[bot] commented 1 year ago

PR Analysis

How to use

To invoke the PR-Agent, add a comment using one of the following commands: /review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option. /describe: Modify the PR title and description based on the contents of the PR. /improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback. /ask \<QUESTION>: Pose a question about the PR. /update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value For example: /review --pr_reviewer.extra_instructions="focus on the file: ..." To list the possible configuration parameters, use the /config command.

codecov-commenter commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ee6c029) 93.49% compared to head (0fdd75d) 93.49%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #506 +/- ## ======================================= Coverage 93.49% 93.49% ======================================= Files 28 28 Lines 3027 3027 ======================================= Hits 2830 2830 Misses 197 197 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

samjrholt commented 1 year ago

@lang-m this has fixed the issue. Please merge and update the latest tag if you are happy.