ubermag / micromagneticdata

Python package for the analysis of micromagnetic data.
https://ubermag.github.io
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

Fix: translate field region to align with input #59

Closed lang-m closed 1 year ago

lang-m commented 1 year ago

Mumax3 defines the origin in the lower left corner of the mesh [index (0, 0, 0)]. This causes problems when we try to load subregions from the input files for a region with a different location in space.

codecov-commenter commented 1 year ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0e0d289) 96.03% compared to head (a8ded15) 95.75%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #59 +/- ## ========================================== - Coverage 96.03% 95.75% -0.29% ========================================== Files 7 7 Lines 353 353 ========================================== - Hits 339 338 -1 - Misses 14 15 +1 ``` | [Files](https://app.codecov.io/gh/ubermag/micromagneticdata/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ubermag) | Coverage Δ | | |---|---|---| | [micromagneticdata/abstract\_drive.py](https://app.codecov.io/gh/ubermag/micromagneticdata/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ubermag#diff-bWljcm9tYWduZXRpY2RhdGEvYWJzdHJhY3RfZHJpdmUucHk=) | `96.00% <75.00%> (-1.00%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.