search

ubermag / micromagneticmodel

Python-based domain-specific language for computational magnetism.
http://ubermag.github.io
BSD 3-Clause "New" or "Revised" License
10 stars 8 forks source link

Generic ExternalDriver #47

Closed lang-m closed 2 years ago

lang-m commented 2 years ago

This PR moves generic functionality to drive or schedule a simulation. A new abstract class ExternalDriver is added this can be used as base class for oommfc.Driver and mumax3c.Driver.

Everything specific to an external package (writing input files, calling the simulation, reading results back in) must be implemented the derived classes. ExternalDriver defines abstract methods to specify what functionality is expected.

codecov-commenter commented 2 years ago

Codecov Report

Merging #47 (91e06d0) into master (0810440) will decrease coverage by 1.99%. The diff coverage is 87.64%.

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   99.77%   97.78%   -2.00%     
==========================================
  Files          29       30       +1     
  Lines         454      542      +88     
==========================================
+ Hits          453      530      +77     
- Misses          1       12      +11
Impacted Files Coverage Δ
micromagneticmodel/driver.py 87.50% <86.74%> (-12.50%) :arrow_down:
micromagneticmodel/__init__.py 100.00% <100.00%> (ø)
micromagneticmodel/runner.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0810440...91e06d0. Read the comment docs.