ubermag / micromagneticmodel

Python-based domain-specific language for computational magnetism.
http://ubermag.github.io
BSD 3-Clause "New" or "Revised" License
10 stars 8 forks source link

More flexibility when scheduling runs #72

Closed lang-m closed 1 year ago

lang-m commented 1 year ago

A separate _schedule_commands methods is now used to create all required calculator calls for a script. This is required to take calculator specific details into account, e.g. OOMMF requires calls to launchhost and kill in addition to the "actual" call.

With these changes the dry_run option is not any longer needed in the public interface and therefore I removed it.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4d9428e) 99.82% compared to head (8d615b9) 99.82%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #72 +/- ## ======================================= Coverage 99.82% 99.82% ======================================= Files 30 30 Lines 559 559 ======================================= Hits 558 558 Misses 1 1 ``` | [Impacted Files](https://app.codecov.io/gh/ubermag/micromagneticmodel/pull/72?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ubermag) | Coverage Δ | | |---|---|---| | [micromagneticmodel/runner.py](https://app.codecov.io/gh/ubermag/micromagneticmodel/pull/72?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ubermag#diff-bWljcm9tYWduZXRpY21vZGVsL3J1bm5lci5weQ==) | `96.00% <ø> (-0.30%)` | :arrow_down: | | [micromagneticmodel/driver.py](https://app.codecov.io/gh/ubermag/micromagneticmodel/pull/72?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ubermag#diff-bWljcm9tYWduZXRpY21vZGVsL2RyaXZlci5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

fangohr commented 1 year ago

Content approved.