Open kzqureshi opened 1 month ago
The missing info.json
in schedule
is also the reason for the test failure.
@samjrholt Short summary: info.json
is extended to have a complete start data + time, end date + time, elapsed time, and information about success.
We should deprecate the individual date
and time
keys in info and remove those after some time.
We also move writing the info.json file from the individual calculators to the base class (all required calculator-specific details are available in the base class).
@samjrholt You are right, we should add the ubermag version. Maybe best importlib.metadata.version("ubermag")
?
Attention: Patch coverage is 91.89189%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 98.58%. Comparing base (
4c3dd04
) to head (b93eca7
). Report is 3 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
micromagneticmodel/driver.py | 91.89% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
update_info_json method is added to update and add the additional information to the info.json file.