search

ubermag / oommfc

OOMMF calculator.
http://ubermag.github.io
BSD 3-Clause "New" or "Revised" License
50 stars 17 forks source link

Fix time varying J and tcl injection in `Xf_ThermSpinXferEvolver` #136

Closed swapneelap closed 1 year ago

lang-m commented 1 year ago

Is any of the tests actually running a simulation with time-varying Xf_ThermSpinXferEvolver? If not, we should add a test to micromagnetictests.

swapneelap commented 1 year ago

Is any of the tests actually running a simulation with time-varying Xf_ThermSpinXferEvolver? If not, we should add a test to micromagnetictests.

Yes absolutely! I will add tests. I am also thinking it would be good to reorder a few things in oc.script when it comes to simulations at finite temperature. For example, it is redundant to to ask user for an evolver if both mm.Slonczewski and system.T are defined since oc.Xf_ThermSpinXferEvolver is the only suitable option (?).

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a8efd2c) 93.45% compared to head (581a22f) 93.45%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #136 +/- ## ======================================= Coverage 93.45% 93.45% ======================================= Files 26 26 Lines 1177 1177 ======================================= Hits 1100 1100 Misses 77 77 ``` | [Impacted Files](https://app.codecov.io/gh/ubermag/oommfc/pull/136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ubermag) | Coverage Δ | | |---|---|---| | [oommfc/scripts/evolver.py](https://app.codecov.io/gh/ubermag/oommfc/pull/136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ubermag#diff-b29tbWZjL3NjcmlwdHMvZXZvbHZlci5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

swapneelap commented 1 year ago

@lang-m if this is good for now, should we close this? There relevant test is here.

lang-m commented 1 year ago

@swapneelap Have you created an issue to remind us to rework the tests and get access to mif string? Once that is done, you can merge.

swapneelap commented 1 year ago

@swapneelap Have you created an issue to remind us to rework the tests and get access to mif string? Once that is done, you can merge.

Done!