search

ubermichael / isetools

Tools for parsing data for the Internet Shakespeare Editions
GNU General Public License v2.0
2 stars 3 forks source link

New and improved validators #29

Closed emmental closed 8 years ago

emmental commented 8 years ago

So it's taken me a while to get around to finishing all of these, but here are the new validators! So I've added all of the ones mentioned in the remaining issues:

I also took the tag balance validation out of the NestingValidator (and put it into TagBalanceValidator) since I didn't really feel it belonged there, and at this point NestingValidator is already pretty bloated.

I've added some tests for all of the validators. They could probably use a few more, but so far everything is working (this is all live on the site.

I'm going to be pushing through everything else I have today, too; it's going to be quite a few changes!

emmental commented 8 years ago

I've made the changes that we talked about on Friday. Let me know if there's anything I missed.