ubershmekel / redditp

Convert any reddit page to a presentation or slide show
https://redditp.com
MIT License
261 stars 102 forks source link

Support Github Pages? #117

Closed d33tah closed 4 years ago

d33tah commented 4 years ago

Hi again!

I was playing with redditp and managed to run it without any extra server, after copying index.html to 404.html. Github Pages would then serve this index.html even if I gave it a weird URL and your script worked. Perhaps it would make sense to support this use case?

ubershmekel commented 4 years ago

I'm not sure if that would work because some of the assets would be in the wrong directory. Did you test this idea out?

d33tah commented 4 years ago

@ubershmekel I tested it and it worked, but only if I assigned a domain so that the resources would sit in the root diretory.

d33tah commented 4 years ago

@ubershmekel you can try it out here: https://redditp.d33.pl/

ubershmekel commented 4 years ago

Cool. Perhaps we can add this as a note to the README file? I wouldn't want to actively copy between the two all the time.

d33tah commented 4 years ago

@ubershmekel copy between what exactly? The redditp.d33.pl fork might go down pretty quickly, it was just an experiment. I'm OK with you posting about it in README.md. I guess I mostly just wanted to let you know that you can use Github Pages to host this project.

ubershmekel commented 4 years ago

I added a note to the readme file at https://github.com/ubershmekel/redditp/commit/9a1ce4823bbc307440148c4001f918d79f043569#diff-04c6e90faac2675aa89e2176d2eec7d8

Feel free to reopen if needed and again thank you for the idea.