ubershmekel / redditp

Convert any reddit page to a presentation or slide show

https://redditp.com

MIT License

261 stars 102 forks source link

Overlay #139

Closed JohnnyDarks closed 2 years ago

JohnnyDarks commented 2 years ago

138

Fix for swipes/tapping not working. Basically, just created a transparent overlay that catches the events. It works on my machine, but if anyone else wants to try it, feel free. Also, it breaks the ability to unmute redgifs.

ubershmekel commented 2 years ago

Took me a while to figure out what you meant by "Fix for swipes/tapping not working". Because they were working as far as I'm aware. Then I remembered the recent redgifs iframe business. Thanks for this.

Also, I did notice you snuck in the 64 px change for the overlay. I'll merge it in for now and may remove later.

Why did you change that?

JohnnyDarks commented 2 years ago

Hello, I should have put a comment, but I realized that the redgif seek controls seem to be fixed to be 64px on the bottom of the screen; so I just shortened the overlay so it does not block the controls. I was also still looking for a way to auto enable sound, but cannot figure it out.

TimotheeMalard commented 2 years ago

This PR broke the pictureSlider.playButton usage :)