search

ubershmekel / redditp

Convert any reddit page to a presentation or slide show
https://redditp.com
MIT License
259 stars 101 forks source link

recent commit broke swiping to next item when video is playing #154

Open sander1095 opened 1 year ago

sander1095 commented 1 year ago

I think the culprit is this commit, which fixed stuff for iphone:

https://github.com/ubershmekel/redditp/commit/5636b48a40e1dc305bf19daa62cd4bde0fd333c4

I use Firefox mobile on Android 11, and when I swipe when looking at an image, everything works. But when a video starts playing I can no longer swipe forward/backward. I have to manually select the next item in the list to fix this.

Very annoying! :( But still, thanks for this great project. Use it every day!

ubershmekel commented 1 year ago

Hmm, it seems that swiping still works in Chrome on Android. The problem might also be because of this change https://github.com/ubershmekel/redditp/commit/758f14d22104e1da0ad12da5c5eb06ed7db7aa51#diff-0eb547304658805aad788d320f10bf1f292797b5e6d745a3bf617584da017051

Do you have an idea on how to fix this?

offroadguy56 commented 1 year ago

Can confirm I also cannot swipe on some videos. It appears to only affect redgifs. Using Opera version 73.3.3844.70500 on Android. Mobile mode and desktop mode doesn't seem to fix it. Arrow buttons on left and right still work.