redditp doesnt work when i put in a subreddit however it works when i put in a user

ubershmekel / redditp

Convert any reddit page to a presentation or slide show

https://redditp.com

MIT License

259 stars 101 forks source link

redditp doesnt work when i put in a subreddit however it works when i put in a user #159

Closed kwasiasem closed 11 months ago

kwasiasem commented 11 months ago

as you can see im on chrome and i have a windows 10 computer with the latest update. this is the same on my iphone 12. i have just changed wifi today which may be why? other than that i am not sure and am also unsure if others are experiencing this issue. please try to resolve this

ubershmekel commented 11 months ago

https://redditp.com/r/aww/ works for me in a regular window and an incognito window.

Can you try on another machine?

Can you try to disable all extensions?

SoulSilver08 commented 11 months ago

for some reason it doesn´t work without a slash (/) after the subreddit name in the url Wo_Slash W_Slash

kwasiasem commented 11 months ago

https://redditp.com/r/aww/ works for me in a regular window and an incognito window.

Can you try on another machine?

Can you try to disable all extensions?

seems all i had to do was just put / at the end of the url. still strange since it never use to be like that.

also i tried sending a screenrecording from mobile but its just not sending on github 🤷🏿

ubershmekel commented 11 months ago

Seems that requesting the following:

https://www.reddit.com/r/aww.json?&jsonp=jQuery341017684215129869707_1691731760220&_=1691731760221

Causes a 301 redirect to:

https://www.reddit.com/r/aww.json/?&jsonp=jQuery341017684215129869707_1691731760220&_=1691731760221

I don't know if it's new that reddit does this redirect, or if the browser only recently started to fail on this. But I don't remember this ever being a problem.

Thank you for figuring it out.

Should be fixed in https://github.com/ubershmekel/redditp/commit/ee86dd1f49d5bcb719431565e179d677cb50a81c

Please retest and let me know.

kwasiasem commented 11 months ago

Seems that requesting the following:

https://www.reddit.com/r/aww.json?&jsonp=jQuery341017684215129869707_1691731760220&_=1691731760221

Causes a 301 redirect to:

https://www.reddit.com/r/aww.json/?&jsonp=jQuery341017684215129869707_1691731760220&_=1691731760221

I don't know if it's new that reddit does this redirect, or if the browser only recently started to fail on this. But I don't remember this ever being a problem.

Thank you for figuring it out.

Should be fixed in ee86dd1

Please retest and let me know.

ive tested it works perfectly, thank you