search

ubershmekel / redditp

Convert any reddit page to a presentation or slide show
https://redditp.com
MIT License
259 stars 101 forks source link

Add Skip Gallery Button #175

Open QuantumManiac opened 1 month ago

QuantumManiac commented 1 month ago

Added a "skip" button for galleries so that mobile users without access to the 'g' key can skip a gallery. Looks to be working as expected:

https://github.com/ubershmekel/redditp/assets/8643561/233263fe-b5f1-4ba1-b63f-3ba270033a43

QuantumManiac commented 1 month ago

@ubershmekel sorry for the bump, would you mind taking a quick look? Feature has been (manually) tested and looks to be good to go.

ubershmekel commented 1 month ago

Hi @QuantumManiac that's a cool feature. Thank you for building it. Though the button is located in a place where there has not yet been any navigation button in the past. I believe it will be invisible to most folks. I'm not sure how to solve that though.

QuantumManiac commented 1 month ago

Thanks for the feedback, @ubershmekel ! I was also not too sure on how I would nicely expose this functionality on the UI. My initial thought was to put another "next" button (maybe styled as a fast-forward icon) either above or below the existing "next" icon that is used to go to the next image, but I found that it was a bit awkwardly placed.

My hope is that users would see the gallery page count change and notice the skip button right beside it.

Any thoughts?

ubershmekel commented 1 month ago

The "slide number" buttons are a sort of "skip gallery". Maybe that UI needs to become more prominent somehow.

QuantumManiac commented 1 month ago

The "slide number" buttons are a sort of "skip gallery". Maybe that UI needs to become more prominent somehow.

@ubershmekel Which buttons are you referring to? On the master branch the slide number on the top, below the title, looks to just be a display and doesn't do anything when clicked.

@felixs-alt any recommendations, given that you implemented the gallery functionality?

Given that we're currently not too sure about the best implementation for this, we could just merge what we have, so the functionality is there, and modify it when we come up with a better idea.

felixs-alt commented 3 weeks ago

The "slide number" buttons are a sort of "skip gallery". Maybe that UI needs to become more prominent somehow.

@ubershmekel Which buttons are you referring to? On the master branch the slide number on the top, below the title, looks to just be a display and doesn't do anything when clicked.

@felixs-alt any recommendations, given that you implemented the gallery functionality?

Given that we're currently not too sure about the best implementation for this, we could just merge what we have, so the functionality is there, and modify it when we come up with a better idea.

i have no point to give, im terrible at ui

ubershmekel commented 3 weeks ago

@QuantumManiac I'm talking about the bottom left. Where each slide gets a number and you can click a number to jump between "slides". You can use that to skip a gallery.

QuantumManiac commented 3 weeks ago

@QuantumManiac I'm talking about the bottom left. Where each slide gets a number and you can click a number to jump between "slides". You can use that to skip a gallery.

Okay, that's what I figured. In that case it might be a bit redundant, but I do feel like the decreased overhead (if you can call it that) of finding the current slide number and then clicking on the slide number that goes after it vs. just clicking on a "skip" button might make it worthwhile.