search

ubershmekel / redditp

Convert any reddit page to a presentation or slide show
https://redditp.com
MIT License
261 stars 102 forks source link

Sound enable/disable preference #83

Closed smarek closed 5 years ago

smarek commented 5 years ago

Hi, the same way we currently have nsfw preference, could there be an sound preference?

Simple way is to reflect the preference in muted attribute presence Advanced would be to also transfer the volume level from one video tag to another (javascript accessible property videotag.volume with values from 0.0 to 1.0 meaning 0% to 100% volume)

If you agree with proposal, i'd be willing to create PR for your review

ubershmekel commented 5 years ago

Sounds like a good idea. A PR would be welcome.

smarek commented 5 years ago

Closing as the PR exists #84

murgo commented 4 years ago

Any idea if the audio preference will be merged to master at some point?

ubershmekel commented 4 years ago

Good question @murgo I'll try to get to it ASAP. I realize it's been a long time coming. @jeffjose fyi