search

ubershmekel / redditp

Convert any reddit page to a presentation or slide show
https://redditp.com
MIT License
263 stars 103 forks source link

Added animation settings #87

Open merlin-ka opened 5 years ago

merlin-ka commented 5 years ago

Added an option for enabling/disabling the animations as well as changing the speed of the animations (#86).

If the animation speed is too fast (e.g. 50ms) and you go back to the previous slide, it seems that the video elements don't load fast enough to invoke the .play() method on them (see line 650).

Other than that it works just fine.

ubershmekel commented 5 years ago

Thank you for this @Merlin-CK !

On my machine I wasn't able to break the .play(). The only problem I have is there are quite a bit of UI elements in there especially considering https://github.com/ubershmekel/redditp/pull/84

I'll have to think the UI through. Let me know if you have ideas or opinions on it.