search

ubi-agni / human_hand

modular, articulated human hand model
Other
31 stars 6 forks source link

Minor fixes for executing roslaunch #3

Closed costashatz closed 5 years ago

costashatz commented 5 years ago

This includes a minor fix for making it work in my computer (Ubuntu 18.04, ROS Melodic) and also adding a few parameters in display.launch to make it more parameterizable.

guihomework commented 5 years ago

Thanks for this fix and making the display.launch more parametrizable. When I tried in March on bionic, I fixed the "None" problem in a different way and realized later that you did too. I think the None as correct Python keyword is better than the string 'None'. So I did not merge this part of your fix. I looked at your PR again today and I like the extended parameters, but I prefer the default is the same as before, with synergy on. So I rebased your commit, and merged it in the master maintaining your authorship for this later one. I can close this request as it was fixed in e51741511d1e75baf02066445e5d270f364e828f and 387b970d9b024d11c50a9874a3ec401fe8c914ad

costashatz commented 5 years ago

No problem! Thanks for the code!