search

ubi-agni / mujoco_ros_pkgs

Wrappers, tools and additional API's for using ROS with MuJoCo
54 stars 11 forks source link

Add config and assets dirs to cmake install directory directive #28

Closed LeroyR closed 9 months ago

LeroyR commented 9 months ago

:smiley:

rhaschke commented 9 months ago

I don't see the need to install the config and assets folders, they only comprise development files, don't they? Why is the current handling of GLFW not sufficient in your point of view?

LeroyR commented 9 months ago

the launchfile defaults to files from these folders so assets and config should also be installed (or the launchfile defaults changed)

Also testxml is not installed and thus generate an error message.

Why is the current handling of GLFW not sufficient in your point of view?

removed for now, just generates stupid hints in RDTK 

 No provider for LIBRARY libglfw.so.3
DavidPL1 commented 9 months ago

the launchfile defaults to files from these folders so assets and config should also be installed (or the launchfile defaults changed)

Yes, the proposed change is valid, they should be installed.

Also testxml is not installed and thus generate an error message.

I did not include this as this plugin is only built and utilized during testing. I'm not sure if catkin lint allows settings an exception for such a case. There are a few more catkin lint errors anyways that I will fix soon, so this will be handled.