ubi-agni / ros-builder-action

Github action to build .deb packages from ROS sources
https://ros.packages.techfak.net
5 stars 5 forks source link

Use os-release's "VERSION_CODENAME" to populate the right distro name in the apt source list #18

Closed mikaelarguedas closed 2 weeks ago

mikaelarguedas commented 2 weeks ago

This allows to build images for Ubuntu 24.04 by passing --build-arg DEB_DISTRO=noble


Without this change building with --build-arg noble results in:

3.972 The following packages have unmet dependencies:
4.025  ros-one-rosbag : Depends: libboost-regex1.74.0-icu70 but it is not installable
4.025                   Depends: ros-one-rosbag-storage but it is not going to be installed
4.025  ros-one-rosconsole : Depends: libboost-regex1.74.0-icu70 but it is not installable
4.025                       Depends: liblog4cxx12 (>= 0.12.1) but it is not installable
4.025  ros-one-rospack : Depends: libpython3.10 (>= 3.10.0) but it is not installable
4.025                    Depends: libtinyxml2-9 (>= 8.0.0) but it is not installable
4.026 E: Unable to correct problems, you have held broken packages.
------
Dockerfile:31
--------------------
  30 |     # install ros packages
  31 | >>> RUN apt-get update && apt-get install -y --no-install-recommends \
  32 | >>>     ros-one-ros-core \
  33 | >>>     && rm -rf /var/lib/apt/lists/*
  34 |     
--------------------
rhaschke commented 2 weeks ago

Thanks for pointing this out!