ubicomplab / rPPG-Toolbox

rPPG-Toolbox: Deep Remote PPG Toolbox (NeurIPS 2023)
https://arxiv.org/abs/2210.00716
Other
486 stars 118 forks source link

Data validation changes #114

Closed yahskapar closed 1 year ago

yahskapar commented 1 year ago

This PR makes two key changes:

  1. Each trainer is modified such that code related to the validation dataset and model selection is NOT executed when USE_LAST_EPOCH is set to True.
  2. Main.py and config.py are modified to better indicate to users whether or not the validation dataset matters and to catch any weird behavior a user may encounter if they modify their configuration file incorrectly.

I don't think the config (YAML) files themselves have to be updated, especially since any additional functionality related to using a validation dataset (e.g., preprocessing, loading) should only ever occur if a validation dataset is actually being used for model selection in subsequent testing.