ubicomplab / rPPG-Toolbox

rPPG-Toolbox: Deep Remote PPG Toolbox (NeurIPS 2023)
https://arxiv.org/abs/2210.00716
Other
482 stars 117 forks source link

Use rindex instead of index for split_idx #125

Closed yahskapar closed 1 year ago

yahskapar commented 1 year ago

As the title suggests. I think this makes more sense than how it currently is based on how input files get saved in the first place. rindex basically finds the last occurrence of a specified value. Since input{chunk_id} is guaranteed to be at the end of the input filename, rindex makes more sense to use in case a passed in item_pathfilename ever had more than one `in it andindexreturned an erroneoussplitidxbecause it just happened to find thein something likesubject_c`.

yahskapar commented 1 year ago

Tested with PURE_UNSUPERVED.yaml and everything appears to be ok. Also verified that printing out certain variables in the BaseLoader made sense.

yahskapar commented 1 year ago

@xliucs updated the commit with some comments that are a bit verbose, but hopefully they're helpful.