search

ubicomplab / rPPG-Toolbox

rPPG-Toolbox: Deep Remote PPG Toolbox (NeurIPS 2023)
https://arxiv.org/abs/2210.00716
Other
442 stars 106 forks source link

Missing averaging of appearance branch input frames for MTTS-CAN model #239

Closed bulbarb closed 7 months ago

bulbarb commented 7 months ago

Hello,

in the original implementation of the MTTS-CAN and TS-CAN model and in the corresponding paper, an averaging of the input frames for the appearance branch is performed. However, after looking closely at this repository, I could not find a corresponding implementation of it. When I look at the input data for the MTTS-CAN model in the debugger, no averaging of the appearance branch input data seems to have been performed there either. Instead, all standardized input frames are processed in the appearance branch. May there be an incorrect implementation of the data preprocessing for the appearance branch or am I missing something?

xliucs commented 7 months ago

Hi @bulbarb ， thanks for your interests. The purpose of averaging input frames is mainly for improving effiency. To simplfy t he implementation, we did not this step in this toolbox.

bulbarb commented 7 months ago

Alright, that seems reasonable. Thanks a lot for the quick reply.