search

ubicomplab / rPPG-Toolbox

rPPG-Toolbox: Deep Remote PPG Toolbox (NeurIPS 2023)
https://arxiv.org/abs/2210.00716
Other
459 stars 112 forks source link

Fix typo in PhysFormer infer configs #261

Closed yahskapar closed 6 months ago

yahskapar commented 6 months ago

This is a simple fix to modify the config's model name entry from "Tscan" to "PhysFormer" for all of the infer configs related to the PhysFormer model.

McJackTang commented 6 months ago

@yahskapar Well, it seems more changes should be applied to the model description of the config. Old TSCAN:

MODEL:
  DROP_RATE: 0.2
  NAME: Tscan
  TSCAN:
    FRAME_DEPTH: 10

New PhysFormer

MODEL:
  DROP_RATE: 0.1
  NAME: PhysFormer
  PHYSFORMER:                     # Probably need to update these in some meaningful way
    PATCH_SIZE: 4
    DIM: 96
    FF_DIM: 144
    NUM_HEADS: 4
    NUM_LAYERS: 12
    THETA: 0.7
yahskapar commented 6 months ago

Good catch @McJackTang, my bad - should be fixed now.