ubicomplab / rPPG-Toolbox

rPPG-Toolbox: Deep Remote PPG Toolbox (NeurIPS 2023)
https://arxiv.org/abs/2210.00716
Other
504 stars 129 forks source link

iBVP dataset, iBVPNet model and MACC evaluation metrics #262

Closed jnj256 closed 7 months ago

jnj256 commented 7 months ago

Dear rPPG-Toolbox team,

Below we summarize our contributions that have been published in our recent work on iBVP dataset.

Through our work, we primarily contribute a novel rPPG dataset, which we refer to as 'iBVP dataset'. Additionally, we introduce iBVPNet model, which was found to be an effective 3D-CNN architecture, with results presented in the paper. We further discover the use of maximum amplitude of cross-correlation (MACC) as highly suitable evaluation metrics to validate rPPG methods.

Researchers will be able to access our dataset by referring to the details mentioned on this GitHub page.

Our code builds upon the rPPG-Toolbox repo, and all the contributions from our side can be found in this forked repo. We would like to create a pull request to merge our contributions. For the same, we summarize the key changes below, and provide a link for detailed difference log.

Added:

Updated:

yahskapar commented 7 months ago

I will get to testing and reviewing this PR fully by this weekend @jnj256 - sorry for the wait!

jnj256 commented 7 months ago

I will get to testing and reviewing this PR fully by this weekend @jnj256 - sorry for the wait!

Thanks Akshay for the update. I identified few refinements for which I shall raise a separate PR later, as these should not affect your testing. For e.g., at line 139 of metrics.py, there should be no unit for MACC ("dB" needs to be removed).

jnj256 commented 7 months ago

@yahskapar : Thank you for going through all the changes made and for your suggestions. I've now addressed your comments and suggestions. Please have a look if everything looks good to go.

yahskapar commented 7 months ago

@jnj256, looks like there's some conflicts, probably because of the OMIT PR that was merged recently. Can you pull those changes and make sure to resolve any conflicts? You should be good to squash and merge after that - thanks again for your contribution!

jnj256 commented 7 months ago

@yahskapar : Thanks for your quick review of the changes. About the conflict related to OMIT PR, I've now resolved it.