search

ubie-oss / ubie-icons

https://ubie-oss.github.io/ubie-icons/storybook-static/
MIT License
27 stars 3 forks source link

chore: 🤖 improve release action #33

Closed kodai3 closed 4 months ago

kodai3 commented 5 months ago

Same release action introduced in the https://github.com/ubie-oss/ubie-ui

takanorip commented 4 months ago

@kodai3 I would like you to make changes so that rather than pushing directly to the main branch, a release pull request is created, and once it is merged, the package is published. Thank you!

kodai3 commented 4 months ago

@takanorip I updated the actions to create PR before publish. It will work as follows

You can create a PR by workflow dispatch, selecting semver versions

image

Then, PR with what's Changed and diff for package.json and package-lock.json are created

image

When you merge to the main branch, publish.yml will be fired and release to the npm registory.

takanorip commented 4 months ago

@kodai3 I'm sorry that the code review wasn't thorough enough. Please check these comments 🙏