search

ubiety / Ubiety.Dns.Core

Flexible DNS library for .NET Core, and .NET Framework
Apache License 2.0
8 stars 6 forks source link

Ubiety.Dns.Core 4.2.1 no longer supports .NET Framework #26

Closed LeadAssimilator closed 2 years ago

LeadAssimilator commented 3 years ago

Describe the bug Ubiety.Dns.Core 4.2.1 only supports net5.0 and .NETStandard,Version=v2.1. This makes the assembly entirely unusable on all .NET Framework versions. Version 4.2.0 however is properly targeting .NETFramework,Version=v4.5.2, .NETFramework,Version=v4.7.1 and .NETStandard,Version=v2.0.

If this change is intentional, then the major version should have been changed to indicate protentional compatibility issues. However, I'm not sure why it would be intentional, since the .NET Framework is still heavily in use and should remain supported. At the very least targeting .NETStandard,Version=v2.0 would allow its use on .NET Framework v4.6.1 and later - see https://docs.microsoft.com/en-us/dotnet/standard/net-standard - but it would be better if it supported the same targets as version 4.2.0.

Expected behavior Ubiety.Dns.Core 4.2.1 should target the same framework versions as Ubiety.Dns.Core 4.2.0.

coder2000 commented 3 years ago

I apologize for the oversight and will attempt to fix it soon however work is dominating my time. If you submit a pull request I will gladly take a look.

coder2000 commented 3 years ago

I have yet to cut a release for it but the develop branch should work with anything supporting .NET Standard 2.0 now.

coder2000 commented 2 years ago

Sorry it took so long but version 4.2.2 is available on NuGet and should support .NET Framework again.