search

ubiety / Ubiety.Dns.Core

Flexible DNS library for .NET Core, and .NET Framework
Apache License 2.0
8 stars 6 forks source link

Fix reading text field of TXT Record #47

Closed EdwinVanVliet closed 1 year ago

EdwinVanVliet commented 1 year ago

Reading the Text field of a TXT Record did not work due to length property in the constructor of the RecordTxt.cs class always being 0. We can simply use the RecordReader.ReadString function as this takes into account the TXT Length.

coder2000 commented 1 year ago

The logging interface was designed to be log library independent so you could map it to Serilog or whatever your choice is. Replacing it whole hog is not recommended. Beyond that the updates to the text reading look OK.

EdwinVanVliet commented 1 year ago

The logging interface was designed to be log library independent so you could map it to Serilog or whatever your choice is. Replacing it whole hog is not recommended. Beyond that the updates to the text reading look OK.

Hi Dieter,

Due to the fact the log library uses a GPL3.0 license I had to remove it in my project. Is it possible to change the license of that component to Apache 2.0, so it is the same as the Ubiety.Dns.Core package?

In that case I can revert my change and re-open the PR for reading the TXT Records.

coder2000 commented 1 year ago

Sorry, I thought I had made it a more permissive license. It should have been Apache 2.0 along with the DNS lib.

EdwinVanVliet commented 1 year ago

I created a new PR without the logging changes.

https://github.com/ubiety/Ubiety.Dns.Core/pull/51

Is it possible that your create a new nuget for the Ubiety.Dns.Logging and Ubiety.Dns.Core package after the PR completed? There are also some other people waiting on the fix for the TXT Records.

Thanks in advance!