search

ubilabs / google-maps-react-hooks

The JavaScript library to easily implement a Google Maps map into your react application. It comes with a collection of React hooks to access the map instance or different Maps JavaScript Services.
MIT License
77 stars 13 forks source link

fix(package): make environment variables work properly for all platforms #122

Closed BiniCodes closed 1 year ago

BiniCodes commented 1 year ago

Can you double check if applied right, @plumdumpling https://www.npmjs.com/package/cross-env#cross-env-vs-cross-env-shell

Also please check if I forgot sth, I think/hope I got all of them.

BiniCodes commented 1 year ago

Let's see if it works 🙂

Needed to remove it and add a note for windows users as tests are failing this way. https://github.com/ubilabs/google-maps-react-hooks/actions/runs/3463634036/jobs/5784142887

I guess it is what he is saying here:

Now I have to figure out how to use a different .npmrc per platform so every developer doesn't have to create their own config file. 😕

@plumdumpling Do you think we should add the note to all the example readmes below the api key instruction as well?

plumdumpling commented 1 year ago

@plumdumpling Do you think we should add the note to all the example readmes below the api key instruction as well?

I think this is only needed in the development and to start the examples, right? So I think you can remove the Windows instructions from the library README and add it to the examples README. Can you please also add a comment to our internal Troubleshooting issue, so that we don't forget to add this to the Troubleshooting Guide.

BiniCodes commented 1 year ago

@plumdumpling Do you think we should add the note to all the example readmes below the api key instruction as well?

I think this is only needed in the development and to start the examples, right? So I think you can remove the Windows instructions from the library README and add it to the examples README. Can you please also add a comment to our internal Troubleshooting issue, so that we don't forget to add this to the Troubleshooting Guide.

As far as I understood in the issue, the installation of the library neither worked - because of the env variables. But this could also be because of the postinstall in the older version.