ubilabs / hcu-unitac-dipas

Cloned from https://bitbucket.org/geowerkstatt-hamburg/dipas/src/dev/
GNU General Public License v2.0
0 stars 1 forks source link

Make all CoSI- UI elements translatable #6

Open ehundt opened 1 year ago

ehundt commented 1 year ago

Original specification: "Ermöglichung der Übersetzungen für alle CoSI-UI-Elemente (Standard: Englisch)."

ehundt commented 1 year ago

As stated in our meeting with Daniel on 27.2: In the config.json file which is located in the mpportals repository we will only make the top menu items translatable. We add keys for English translations starting with "TODO en: "

ehundt commented 1 year ago

TODOs:

BastianGuenther commented 1 year ago

Testing

BastianGuenther commented 1 year ago

Unit tests mit Daniel klären:

BastianGuenther commented 1 year ago

Elli checkt die Readme für die Unit Tests.

ehundt commented 1 year ago

This is how I ran the tests:

Result of the unit tests: All green except one: addons/cosi/Dashboard/test/unit/utils/tableCell.spec.js?:17:95:

expected '2,266' to equal '2.266'

plus a few error messages. These issues are present in main branch already.

Manual testing:

ehundt commented 1 year ago

Be aware that the changes in the mpportals repo may not be merged before the translation changes are merged to the cosi repo. Otherwise the translation keys will be displayed.

ehundt commented 1 year ago

-

ehundt commented 1 year ago

In cosi/Dashboard/components/Dashboard.vue I am using i18nOptions: { keyPrefix: ...}

From my point of view it would be cleaner to use this i18n prefix - we don't have to use the whole path everywhere. But I thought there is maybe a reason why it has not been used so far? That s why I didn't add it to the other components...