ubipo / osmfocus

Open source tool for examining OpenStreetMap elements by moving around on a map.
Apache License 2.0
43 stars 5 forks source link

Handle long text in tags blocking view #4

Closed daniel-j-h closed 3 years ago

daniel-j-h commented 3 years ago

Hey hey,

awesome to see you reviving osm focus, I was missing this for years! :heart:

Here's what I noticed: when there is long text in tags, the boxes get quite big blocking most of the map view.

Can we handle this in a smart way? For example wrapping the line, abbreviating the text, or similar?

Screenshot_20210313-022807

daniel-j-h commented 3 years ago

Here is a second example where the boxes block each other's visibility

Screenshot_20210313-025538

ubipo commented 3 years ago

First off: thank you so much for the donation, means a lot! :heart:

Yeah, haven't been active for a bit but I did have two ideas to improve the situation:

For the second one: this ties in nicely with abbreviating stuff, both horizontally and vertically with an ellipsis.

Also like line-wrap, I'll look into that.

ubipo commented 3 years ago

Took a while, but I just released v1.0.1: https://github.com/ubipo/osmfocus/releases/tag/v1.0.1

For this specifically I implemented:

I still want to add the click-for-more details thing and an option to hide some of the tagboxes (and for example only show the corner ones), but I'm closing this for now.

Let me know what you think!

Google Play release is in review and f-Droid needs to have a PR approved first: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/8738 You can of course just download the APK from the latest release (it's the fdroid version, but eitherway it shouldn't interfere with autoupdates).

ubipo commented 3 years ago

Alright, PR was merged. Probably a day or so until it updates in the f-Droid app.