ubiq / shokku

An open source scalable blockchain infrastructure for Ubiq, Ethereum, POA and IPFS that runs on Kubernetes
https://api.shokku.com
Apache License 2.0
38 stars 8 forks source link

Dockerize fails to accept generate and build as flags on linux. Added link to docker-compose. #13

Open pancsocks opened 6 years ago

pancsocks commented 6 years ago

Command "npm run dockerize -- generate" and 'npm run dockerize -- build local' failed. Generate and build were not intepreted as flags. The issue with passing -- generate to npm run dockerize may only be linux specific?

codecov-io commented 6 years ago

Codecov Report

Merging #13 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   39.49%   39.49%           
=======================================
  Files          22       22           
  Lines         433      433           
=======================================
  Hits          171      171           
  Misses        262      262

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25de89c...e436c20. Read the comment docs.

aldoborrero commented 6 years ago

Hi @gdfreeman

NPM says when you want to run args commands (not flags) to be passed to the script you have to follow this:

The syntax is as follows: npm run [-- ] Note the necessary --. It is needed to separate the params passed to npm command itself and params passed to your script.

As stated here in this StackOverflow answer.

Can you share which errors are you having when running the commands on Linux?

blanksteer commented 6 years ago

@aldoborrero

Looked into this issue. The commands work as expected on Linux. However would you consider my changes to dockerize.js? I didn't see (maybe i missed) any code that checks for the directory docker/compose. Added directory checking and absolute paths to branch test-dockerize. Everything works as expected except for building. Building the dev containers fails for me because of a python version conflict. apk tries to install version "python2-2.7.15-r2". I believe the docker file want's python=2.7.14-r2. Is there a need for that specific python version?

https://github.com/blanksteer/shokku/tree/test-dockerize