ubiquibot / assistive-pricing

0 stars 10 forks source link

feat!: assistive-pricing as a Worker #6

Closed gentlementlegen closed 3 months ago

gentlementlegen commented 4 months ago

Resolves #5

github-actions[bot] commented 4 months ago

Unused devDependencies (5)

Filename devDependencies
package.json @types/jest
esbuild
eslint-config-prettier
eslint-plugin-prettier
ts-node

Unlisted dependencies (1)

Filename unlisted
tests/main.test.ts @jest/globals

Unused exports (4)

Filename exports
src/handlers/pricing-label.ts labelExists
src/shared/label.ts deleteLabel
src/shared/pricing.ts calculateDurations
src/types/typeguards.ts isIssueEvent

Unused types (8)

Filename types
src/types/env.ts Env
src/types/github.ts Comment
Repository
WebhookEvent
src/adapters/supabase/types/database.ts Tables
TablesInsert
TablesUpdate
Enums

Unused Enum Members (2)

Filename Enum Member
src/types/github.ts UserType User
Organization
github-actions[bot] commented 4 months ago
Lines Statements Branches Functions
Coverage: 83%
83.33% (20/24) 66.66% (6/9) 80% (4/5)

JUnit

Tests Skipped Failures Errors Time
2 0 :zzz: 0 :x: 0 :fire: 3.925s :stopwatch:
Coverage Report (83%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files83.3366.668083.33 
src/handlers84.2166.6610084.21 
   command-parser.ts84.2166.6610084.2116, 19, 27
static8010066.6680 
   main.ts8010066.66809
gentlementlegen commented 4 months ago

Major changes

gitcoindev commented 4 months ago

Hi @gentlementlegen there is a small commit needed for knip workflow that removes superflous steps. See comment from @rndquu https://github.com/ubiquity/rpc-handler/pull/13#issuecomment-2123006059 . This does not touch any of your changes, I will add this commit to the pull request.

gitcoindev commented 4 months ago

Hi @gentlementlegen there is a small commit needed for knip workflow that removes superflous steps. See comment from @rndquu ubiquity/rpc-handler#13 (comment) . This does not touch any of your changes, I will add this commit to the pull request.

My bad - I checked and you pulled latest changes already, thank you! I also checked on a local workspace

✂️ Excellent, Knip found no issues.

gitcoindev commented 4 months ago

@gentlementlegen I checked out the pr workspace, and I am able to test locally with jest. Would you mind adding to README.md steps needed to execute and test the worker locally including supabase setup, if needed? I set supabase .dev.vars to my instance but I see {"error":"Error: null is not a valid content type"} when I connect to worker started with yarn worker command and I am not sure what I am missing and what to expect. Perhaps adding this info would make life easier to anyone who would work on the plugin afterwards. I also see cypress is still a placeholder, will it be used in this repository?

gentlementlegen commented 3 months ago

@gitcoindev Thanks for the feedback. I removed Cypress, and added instructions in the README plus a .http test file. Let me know if that is clear enough or if I should add more instructions.

gitcoindev commented 3 months ago

@gentlementlegen thank you for adding the example, I am approving the pull request from my side.