search

ubiquibot / conversation-rewards

0 stars 10 forks source link

chore: tests for special characters #19

Closed gentlementlegen closed 2 months ago

gentlementlegen commented 2 months ago

Resolves #18

gentlementlegen commented 2 months ago

Added tests to make sure the serialization for complex comments works and we don't get regressions, since before it sometimes resulted in a broken UI due to HTML being interpreted when it was just the content of the comment. See this file for reference of what is tested, and this issue for run results.

rndquu commented 2 months ago

@molecula451 Why did you merge it with failing tests?

molecula451 commented 2 months ago

@molecula451 Why did you merge it with failing tests?

I approved the PR here. I did not merged, gentleman merged, in any case, i think gentleman is aware of the failing tests run

image_2024-05-16_050100027

gentlementlegen commented 2 months ago

@rndquu @molecula451 yes checking in the next PR since it contains more tests so was easier to fix all of them at the same time, will update all of them at once